Mislabeled text in ITAD classes #192

New issue

Closed

opened 2025-12-18 22:08:19 -05:00 by sirdog3355 · 1 comment

sirdog3355 commented

2025-12-18 22:08:19 -05:00

(Migrated from github.com)

le sigh

In PR #180 I reworked a lot of the error handling and thus the text it sends. However, some of the text reports there's an error at an endpoint which isn't being checked in the block.

Ergo:

if not full_data:
    raise APIContentNotFoundError(f"Endpoint [/games/info/v2] returned nothing for UUID [{game_id}].")

if "status_code" in full_data and full_data["status_code"] == 403:
    raise APIConnectionError("Endpoint [/games/search/v1] has rejected EnduraBot's API key.")
elif "status_code" in full_data:
    raise APIConnectionError(f"Endpoint [/games/search/v1] returned status code {full_data["status_code"]} rather than content.")

Instances of [/games/search/v1] need to be replaced with [/games/info/v2].

Should probably review both classes for this as a redundancy measure.

*le sigh* In PR #180 I reworked a lot of the error handling and thus the text it sends. However, some of the text reports there's an error at an endpoint which isn't being checked in the block. Ergo: ```py if not full_data: raise APIContentNotFoundError(f"Endpoint [/games/info/v2] returned nothing for UUID [{game_id}].") if "status_code" in full_data and full_data["status_code"] == 403: raise APIConnectionError("Endpoint [/games/search/v1] has rejected EnduraBot's API key.") elif "status_code" in full_data: raise APIConnectionError(f"Endpoint [/games/search/v1] returned status code {full_data["status_code"]} rather than content.") ``` Instances of `[/games/search/v1]` need to be replaced with `[/games/info/v2]`. Should probably review both classes for this as a redundancy measure.

sirdog3355 commented

2025-12-18 22:47:01 -05:00

(Migrated from github.com)

Addressed in PR #193. Documentation does not need to be updated. Closing as completed.