Remove redundant variables #22

New issue

Closed

opened 2025-10-10 22:21:24 -04:00 by sirdog3355 · 1 comment

sirdog3355 commented

2025-10-10 22:21:24 -04:00

(Migrated from github.com)

I do something like this frequently:

        mod_role_id = self.settings_data.get("mod_role_id")
        admin_role_id = self.settings_data.get("admin_role_id")
        guild_mod_role = discord.utils.get(interaction.guild.roles, id=mod_role_id)
        guild_admin_role = discord.utils.get(interaction.guild.roles, id=admin_role_id)

And then I never use mod_role_id or admin_role_id again; they exist solely to fill in discord.utils.get. That seems wasteful.

I should just do:

guild_mod_role = discord.utils.get(interaction.guild.roles, id=self.settings_data.get("mod_role_id"))

Desired result is to refactor the code accordingly.

I do something like this frequently: ```python mod_role_id = self.settings_data.get("mod_role_id") admin_role_id = self.settings_data.get("admin_role_id") guild_mod_role = discord.utils.get(interaction.guild.roles, id=mod_role_id) guild_admin_role = discord.utils.get(interaction.guild.roles, id=admin_role_id) ``` And then I never use `mod_role_id` or `admin_role_id` again; they exist solely to fill in `discord.utils.get`. That seems wasteful. I should just do: ```python guild_mod_role = discord.utils.get(interaction.guild.roles, id=self.settings_data.get("mod_role_id")) ``` Desired result is to refactor the code accordingly.

sirdog3355 commented

2025-10-13 06:45:38 -04:00

(Migrated from github.com)

Closed by #38