Sirdog/EnduraBot
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases 27 Packages Wiki Activity Actions

Fix edge case where join embed is not generated if invite was single use #305

Merged
Sirdog merged 1 commit from bug/join-log-fail into dev 2026-05-03 02:52:12 -04:00
Conversation 0 Commits 1 Files changed 1 +4 -2
Sirdog commented 2026-05-03 02:52:07 -04:00
Owner
Copy link

A simple little error discovered by #298.

The Invite to Server option in Discord's DM generates a single use invite. Most invites generated last 7 or so days. EnduraBot's code was reliant on the invite existing both before and after the user joined. If this wasn't the case, it would not send an embed and throw the error in the aforementioned issue.

This PR addresses that by treating an invite existing in the past, but no longer existing after a user joins, as it being a successful match to the incoming user.

Closes #298

A simple little error discovered by #298. The `Invite to Server` option in Discord's DM generates a single use invite. Most invites generated last 7 or so days. EnduraBot's code was reliant on the invite existing both before and after the user joined. If this wasn't the case, it would not send an embed and throw the error in the aforementioned issue. This PR addresses that by treating an invite existing in the past, but no longer existing after a user joins, as it being a successful match to the incoming user. Closes #298
Sirdog self-assigned this 2026-05-03 02:52:07 -04:00
Sirdog deleted branch bug/join-log-fail 2026-05-03 02:52:12 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something is wrong or not working as intended

  
config update
Live configuration must be updated

  
documentation
Issue/PR only relates to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
Existing functionality is improved

  
in dev
Issue has had a PR merged into dev

  
input needed
Cannot continue work without input from someone else.

  
new feature
New functionality is introduced

  
not in draft
Contents not yet added to drafted release notes

  
refactor
Existing functionality is reworked

  
waiting on docs update
Documentation must be updated before closing

  
wont-do
This will not be worked on.

No labels
bug
config update
documentation
duplicate
enhancement
in dev
input needed
new feature
not in draft
refactor
waiting on docs update
wont-do
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
Sirdog
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Sirdog/EnduraBot!305
No description provided.