Sirdog/EnduraBot
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases 27 Packages Wiki Activity Actions

JSON loading centralized, daily bibleq execution made a configuration #56

Merged
sirdog3355 merged 1 commit from refact/centralize-json into dev 2025-10-18 22:01:48 -04:00
Conversation 0 Commits 1 Files changed 7 +42 -123
sirdog3355 commented 2025-10-18 22:01:30 -04:00 (Migrated from github.com)
Copy link

The loading of JSON configuration has been centralized to a new config_loader.py file that is imported into the cogs. As part of this revamp various imports seen as unused by my IDE of choice were also cleaned.

As a direct result of this PR, the hour and minute when EnduraBot should send the bible quote has become configurable via variables.json with variables_example.json updated to reflect the expected variables.

Closes #53 and #37

The loading of JSON configuration has been centralized to a new `config_loader.py` file that is imported into the cogs. As part of this revamp various `imports` seen as unused by my IDE of choice were also cleaned. As a direct result of this PR, the hour and minute when EnduraBot should send the bible quote has become configurable via `variables.json` with `variables_example.json` updated to reflect the expected variables. Closes #53 and #37
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something is wrong or not working as intended

  
config update
Live configuration must be updated

  
documentation
Issue/PR only relates to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
Existing functionality is improved

  
in dev
Issue has had a PR merged into dev

  
input needed
Cannot continue work without input from someone else.

  
new feature
New functionality is introduced

  
not in draft
Contents not yet added to drafted release notes

  
refactor
Existing functionality is reworked

  
waiting on docs update
Documentation must be updated before closing

  
wont-do
This will not be worked on.

No labels
bug
config update
documentation
duplicate
enhancement
in dev
input needed
new feature
not in draft
refactor
waiting on docs update
wont-do
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Sirdog/EnduraBot!56
No description provided.